Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace viewif with ShouldShow #668

Closed
kkoreilly opened this issue Dec 25, 2023 · 2 comments
Closed

Replace viewif with ShouldShow #668

kkoreilly opened this issue Dec 25, 2023 · 2 comments
Assignees
@kkoreilly
Labels
enhancement A new feature request
Milestone
v0.3

Comments

@kkoreilly
Copy link
Member

kkoreilly commented Dec 25, 2023 •
edited
Loading

No description provided.

@kkoreilly kkoreilly self-assigned this Dec 25, 2023
@kkoreilly kkoreilly added the enhancement A new feature request label Dec 25, 2023
@kkoreilly kkoreilly added this to the v2 milestone Dec 25, 2023
rcoreilly added a commit that referenced this issue Feb 3, 2024
@rcoreilly
Validator, FieldValidator, ShouldShower interfaces -- for #668 #31
d496119
kkoreilly added a commit that referenced this issue Feb 3, 2024
@kkoreilly
pass type of view to ShouldShower for #668
ffa5fb3
@kkoreilly kkoreilly changed the title Allow for context specific conditions in viewif Allow for context specific conditions in viewif and replace viewif with ShouldShow Feb 3, 2024
@kkoreilly
Copy link
Member Author

We are replacing viewif with a ShouldShow method in the ShouldShower interface, which will make things a lot cleaner and reduce binary sizes (#733) by removing the expr dependency. This is in accordance with Principle 1: Code is always the best solution.

kkoreilly added a commit that referenced this issue Feb 4, 2024
@kkoreilly
use ShouldShower instead of viewif in StructView and StructViewInline…
bfb0111 
… for #668
kkoreilly added a commit that referenced this issue Feb 4, 2024
@kkoreilly
removed old view if code for #668
9a72ec3
kkoreilly added a commit that referenced this issue Feb 4, 2024
@kkoreilly
update views example to use ShouldShow for #668
6fd3766
@kkoreilly kkoreilly changed the title Allow for context specific conditions in viewif and replace viewif with ShouldShow Replace viewif with ShouldShow Feb 4, 2024
kkoreilly added a commit that referenced this issue Feb 4, 2024
@kkoreilly
stop passing type to ShouldShow for #668
8a9de37
kkoreilly added a commit that referenced this issue Feb 4, 2024
@kkoreilly
support tableview:+ to display a field in a table view but not a stru…
23d1a11 
…ct view for #668
@kkoreilly
Copy link
Member Author

This has been implemented in the commits above.

kkoreilly added a commit that referenced this issue Feb 9, 2024
@kkoreilly
cleaned up remaining viewif usage for #668
21207bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkoreilly kkoreilly

Labels
enhancement A new feature request
Projects
None yet
Milestone
v0.3
Development

No branches or pull requests
1 participant
@kkoreilly