You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
icalendar.timezone.tzid.tinfo2tzids (which I added) would provide us with a timezone name for a timezone even if this timezone is not easily recognized as having one, so we can generate timezones if needed.
Now, the code assumes that timezones in the past would not change.
But they do! Even between 1970 and 2000.
To Reproduce
Here is an example of how the timezone definitions are different between each other, using EET which is +2 hours away from UTC.
possible reduction of risk if this occurs again: We can assume that timezone changes happen around midnight. Thus we could reduce the tests cases to the hours around midday to reduce ambiguous timezone definitions.
The text was updated successfully, but these errors were encountered:
niccokunzmann
changed the title
[BUG] timezone definitions keep changing
[BUG] timezone definitions keep changing but are assumed static
Feb 6, 2025
Describe the bug
icalendar.timezone.tzid.tinfo2tzids (which I added) would provide us with a timezone name for a timezone even if this timezone is not easily recognized as having one, so we can generate timezones if needed.
Now, the code assumes that timezones in the past would not change.
But they do! Even between 1970 and 2000.
To Reproduce
Here is an example of how the timezone definitions are different between each other, using EET which is +2 hours away from UTC.
So, we can determine pytz and zoneinfo easily because they have a name in them. Dateutil timezones do not have this.
Expected behavior
I would like to be always able to get the correct timezone name for a timezone.
This is hard though!
Environment
icalendar
version: main (6.1.1)Additional context
Ideas to go forward
The text was updated successfully, but these errors were encountered: