Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with core-js v3 #50

Closed
vsolanogo opened this issue Nov 24, 2019 · 8 comments
Closed

Doesn't work with core-js v3 #50

vsolanogo opened this issue Nov 24, 2019 · 8 comments
Labels
Milestone

Comments

@vsolanogo
Copy link

Works fine with v2, will this package be updated in the future to support v3?

detailed error:
success run queries - 6.543s - 236/236 36.07/s

ERROR #98123 WEBPACK

Generating SSR bundle failed

Cannot find module 'core-js/modules/es6.regexp.to-string'

File: .cache\develop-static-entry.js

@silvenon
Copy link
Collaborator

silvenon commented Nov 24, 2019

Unfortunately, this seems to be a problem upstream. 😕 callstack/linaria#420

@cometkim
Copy link
Owner

cometkim commented Dec 8, 2019

And also gatsby, they still use core-js v2 and planned to drop it in gatsby 3. (yeah it's long term plan)

@gu-stav
Copy link

gu-stav commented Feb 21, 2020

Hi, I just wanted to ask what the status of this issue is? As far as I can see core-js v3 support was added in the recent beta and it seems, that this issue should be resolved according to callstack/linaria#539.

I tried installing [email protected] but got the same error. Do we need to extend the babel config mentioned in callstack/linaria@c67f40d?

@silvenon
Copy link
Collaborator

silvenon commented Feb 28, 2020

Apart from incorrectly built stable versions of Linaria, the problem was also the discrepancy in versions of core-js between Linaria and Gatsby, so the full workaround is to also install core-js v3 locally:

yarn add linaria@^1.4.0-beta.3
yarn add core-js

I also documented this in the readme under "Known issues".

@BlackFenix2
Copy link

@silvenon yep, thats pretty much what i had to do for my local project.

@cometkim
Copy link
Owner

This will be fixed in linaria@next (v2.0) they will not depend on core-js anymore

@cometkim cometkim added this to the v3 milestone Jul 6, 2020
@cometkim
Copy link
Owner

And Gatsby finally switched their core-js dependency to version 3

gatsbyjs/gatsby#15601

@cometkim
Copy link
Owner

Linaria v2 has been released without core-js dependency. closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants