Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ADD <git ref> in Containerfile via SSH address #5913

Open
ctlong opened this issue Jan 17, 2025 · 1 comment
Open

Support for ADD <git ref> in Containerfile via SSH address #5913

ctlong opened this issue Jan 17, 2025 · 1 comment
Assignees

Comments

@ctlong
Copy link

ctlong commented Jan 17, 2025

This is an extension of #4974. As of the completion of that issue, the following is supported:

ADD https://github.com/user/repo.git /mydir/

However, buildah's matching only works on HTTP addresses, while Docker allows SSH addresses to be used as well: https://docs.docker.com/reference/dockerfile/#adding-files-from-a-git-repository. This is particularly useful when dealing with private repos, which are typically cloned using SSH key authentication.

I propose adding support for the git@ prefix in SRC to signal that SRC is a git repo to be cloned using SSH.

@danishprakash
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants