Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallelize unit tests which cannot be parallelized because of NewBuilder() #5967

Open
flouthoc opened this issue Feb 3, 2025 · 0 comments
Open

Parallelize unit tests which cannot be parallelized because of NewBuilder() #5967

flouthoc opened this issue Feb 3, 2025 · 0 comments
Assignees
@flouthoc

Comments

@flouthoc
Copy link
Collaborator

flouthoc commented Feb 3, 2025

Certain test cannot be parallized as this uses NewBuilder()
which eventually and indirectly accesses a global variable
defined in go-selinux, this must be fixed at go-selinux
or builder must enable sometime of locking mechanism i.e if
routine is creating Builder other's must wait for it.

This is a tracker issue for changes in #5954
@flouthoc flouthoc self-assigned this Feb 3, 2025
flouthoc added a commit to flouthoc/buildah that referenced this issue Feb 3, 2025
@flouthoc
unit: deparallize some tests
f0cce62 
See issue: containers#5967

Signed-off-by: flouthoc <[email protected]>
@flouthoc flouthoc changed the title Parallize unit tests which cannot be because of NewBuilder() Parallelize unit tests which cannot be parallelized because of NewBuilder() Feb 3, 2025
@flouthoc flouthoc mentioned this issue Feb 3, 2025
Merged
flouthoc added a commit to flouthoc/buildah that referenced this issue Feb 4, 2025
@flouthoc
unit: deparallize some tests
1feb435 
See issue: containers#5967

Signed-off-by: flouthoc <[email protected]>
flouthoc added a commit to flouthoc/buildah that referenced this issue Feb 4, 2025
@flouthoc
unit: deparallize some tests
1e38738 
See issue: containers#5967

Signed-off-by: flouthoc <[email protected]>
flouthoc added a commit to flouthoc/buildah that referenced this issue Feb 4, 2025
@flouthoc
unit: deparallize some tests
de3c3ba 
See issue: containers#5967

Signed-off-by: flouthoc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flouthoc flouthoc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flouthoc