Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail earlier when a layer copy fails #2698

Open
mtrmac opened this issue Jan 28, 2025 · 0 comments
Open

Fail earlier when a layer copy fails #2698

mtrmac opened this issue Jan 28, 2025 · 0 comments
Labels
kind/feature A request for, or a PR adding, new functionality

Comments

@mtrmac
Copy link
Collaborator

mtrmac commented Jan 28, 2025

Currently, if a layer copy while copying an image causes a hard failure, we still continue to copy all other layers to completion, and we only detect the error after all other layer copies finish.

That can probably be improved — on an error, at the very least don’t schedule any layer copies that didn’t yet start. Probably, immediately cancel the context (and then correctly report the right error).

See also the various “This can take quite some time” comments around non-obviously-cancellable io.Copy calls, and look for other relevant locations (e.g. dockerImageSource.GetBlobAt doesn’t do much about cancellation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A request for, or a PR adding, new functionality
Projects
None yet
Development

No branches or pull requests

1 participant