Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.4 image is does not contain podman 5.4 #75

Closed
Luap99 opened this issue Jan 31, 2025 · 2 comments
Closed

5.4 image is does not contain podman 5.4 #75

Luap99 opened this issue Jan 31, 2025 · 2 comments

Comments

@Luap99
Copy link
Member

Luap99 commented Jan 31, 2025

Something is badly broken in the 5.4 build process.

Looking at logs:

Downloading https://kojipkgs.fedoraproject.org/packages/podman/5.4.0-rc2/1.fc41/aarch64/podman-5.4.0-rc2-1.fc41.aarch64.rpm...failed
error: Handling argument https://kojipkgs.fedoraproject.org/packages/podman/5.4.0-rc2/1.fc41/aarch64/podman-5.4.0-rc2-1.fc41.aarch64.rpm: HTTP status client error (404 Not Found) for url (https://kojipkgs.fedoraproject.org/packages/podman/5.4.0-rc2/1.fc41/aarch64/podman-5.4.0-rc2-1.fc41.aarch64.rpm)

Why did that not fail the build outright?

Second looks like we are missing an actual version check for the version in the image in the verify suite.

I will take a look on Monday
cc @baude @lsm5
This was referenced Jan 31, 2025
Closed
Merged
Luap99 added a commit to Luap99/podman-machine-os that referenced this issue Feb 3, 2025
@Luap99
fix broken podman version
59c9388 
The rpm version uses the tilde for the rc tag. This was not catched due
missing tests and missing exit code checks in the Containerfile which
both are fixed in the prevoius commits.

Fixes containers#75

Signed-off-by: Paul Holzinger <[email protected]>
Luap99 added a commit to Luap99/podman-machine-os that referenced this issue Feb 3, 2025
@Luap99
fix broken podman version
d2c3437 
The rpm version uses the tilde for the rc tag. This was not catched due
missing tests and missing exit code checks in the Containerfile which
both are fixed in the prevoius commits.

Fixes containers#75

Signed-off-by: Paul Holzinger <[email protected]>
@lsm5
Copy link
Member

lsm5 commented Feb 4, 2025

I guess it won't happen with #64

Installing 1 packages:
  podman-102:5.4.0~dev-1.20250130152252168600.pr24369.67.9f01c0748.fc41.aarch64 (@commandline)
Updating: podman;102:5.4.0~dev-1.20250130152252168600.pr24369.67.9f01c0748.fc41;aarch64;local
Cleanup: podman;5:5.3.1-1.fc41;aarch64;installed

It should handle - v/s ~

@Luap99
Copy link
Member Author

Luap99 commented Feb 4, 2025

Well anything could have happened, the build process was simply broken because it failed to check the install command exit code and it failed to check the actual version inside the image.

Not sure why this was not closed on merge

@Luap99 Luap99 closed this as completed Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lsm5 @Luap99