Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of custom images #902

Closed
mfocko opened this issue Oct 24, 2021 · 4 comments
Closed

Validation of custom images #902

mfocko opened this issue Oct 24, 2021 · 4 comments
Labels
1. Feature request A request for a new feature

Comments

@mfocko
Copy link

mfocko commented Oct 24, 2021

Is your feature request related to a problem? Please describe.
Feature is mainly related to creating custom images for toolbox. Recently I've been trying to create openSUSE Tumbleweed toolbox image, I just copied latest Fedora files and adjusted it for openSUSE (mostly going through the specfiles in Fedora dist-git and looking for the same package in openSUSE). There is just basic description of what should the toolbox image be able to do (e.g. provide some binaries, configs, etc.).

In the end I ended up with an issue that no sudo group was present, which I had to debug either via podman start --attach toolbox or toolbox -v enter toolbox and then missing libcap (resolved same way).

The process is pretty slow, because you have to fix the issues one by one.

Describe the solution you'd like
It would be ideal to have a script that can be run from inside the container, e.g.

 host$ podman run -ti ‹my-custom-toolbox-image›
# download the script from GitHub
image$ bash ./check-image.sh

which would check the requirements and output anything that is not satisfied (or just everything). Something like

[FAIL] `sudo` group exists.
[FAIL] `capsh` executable is in $PATH.
[PASS] `bash` executable is in $PATH.

Describe alternatives you've considered

  1. Could be potentially included in toolbox as a command, something like toolbox validate ‹my-custom-toolbox-image›
  2. Clearly describe the requirements on image, but that might loop back to the current state over time.
@mfocko mfocko added the 1. Feature request A request for a new feature label Oct 24, 2021
@Jmennius
Copy link
Collaborator

Looks related to #385 (there are useful answers) but in that case I was only worrying about documentation.

@debarshiray
Copy link
Member

Yes, let's keep the discussion consolidated at #385

@debarshiray
Copy link
Member

Duplicate of #385

@debarshiray debarshiray marked this as a duplicate of #385 Nov 17, 2021
@debarshiray
Copy link
Member

Thanks for working on the openSUSE Tumbleweed images! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. Feature request A request for a new feature
Projects
None yet
Development

No branches or pull requests

3 participants