Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings app: read current settings and hide server admin ones? #29

Open
poVoq opened this issue Jan 18, 2020 · 1 comment
Open

settings app: read current settings and hide server admin ones? #29

poVoq opened this issue Jan 18, 2020 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@poVoq
Copy link

poVoq commented Jan 18, 2020

In my tests with the settings plugin I noticed that it seems to show a blank state, so it is not possible to see what current settings (for example as defined in the index.html) are already set. This seems to me like a vital function, no?

Furthermore there are a lot of settings that I would not expose to the end user. Is there some plan to hide them?

Thanks!

@deleolajide
Copy link
Member

it is not possible to see what current settings (for example as defined in the index.html) are already set. This seems to me like a vital function, no?

It is, but involves a manual task of getting every default setting value and puting them in the value tag. A PR from anyone free to do that is most welcome :-)

Furthermore there are a lot of settings that I would not expose to the end user. Is there some plan to hide them?

The plugins are templates with the basic functions and features. I recomend that users of this plugin should first customise before using. It is all JSON data in https://github.com/conversejs/community-plugins/blob/master/settings/options.js

@deleolajide deleolajide added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants