Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minutes of expiry date fixed to numeric representation of the current month #132

Closed
bmomut opened this issue Dec 12, 2023 · 1 comment · Fixed by #133
Closed

Minutes of expiry date fixed to numeric representation of the current month #132

bmomut opened this issue Dec 12, 2023 · 1 comment · Fixed by #133
Labels

Comments

@bmomut
Copy link

bmomut commented Dec 12, 2023

Describe the bug

Wrong format in ForgotPasswordManager.php:73 causing minutes value of expiring date to be fixed to the numeric representation of the current month.

image

According to PHP Docs the "m" format in this line stands for "Numeric representation of a month, with leading zeros" and should have been "i" instead which stands for "Minutes with leading zeros".

To Reproduce
Steps to reproduce the behavior:

  1. Request a token.

Expected behavior

Creation of a new token that expires at current date + duration set in the package's config.

Screenshots

"expiredAt" before format -> "expiredAt" after format (expires_in is set to "1500 seconds" ).
image

Desktop (please complete the following information):

  • OS: Debian 12
  • Browser: Firefox
  • Version: 115.5.0esr
@vincentchalamon
Copy link
Contributor

Nice catch, thanks for the report @bmomut!
It has been fixed and released as v1.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants