Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] normalize_repos.py creates weekly issue spam when an issue has 🏷️ **status: label work required** #203

Closed
1 task done
TimidRobot opened this issue Apr 8, 2024 · 0 comments Β· Fixed by #205
Assignees
Labels
πŸ’» aspect: code Concerns the software code in the repository πŸ›  goal: fix Bug fix 🟨 priority: medium Not blocking but should be fixed soon 🏁 status: ready for work Ready for work

Comments

@TimidRobot
Copy link
Member

TimidRobot commented Apr 8, 2024

Description

  • normalize_repos.py creates issue spam when an issue has 🏷️ status: label work required by removing and adding that label
    1. if there is no status: label, 🏷️ status: label work required is added
    2. if there are no label issues, 🏷️ status: label work required is removed
    3. (repeat)

Expectation

We shouldn't spam issues with bad script logic

Logs

  • [Functionality] make og:title differ from <title>, so that third-parties which support Open Graph data import/display utilize an alternate non-hyphenated formatΒ vocabulary-theme#41
  • ❌ 2024-03-31 UTC: Normalize Repos #1549: Scheduled
    • log excerpt (hard wrapped with blank lines between entries for readability):
      2024-03-31 00:20:07,734 β”‚ INFO     β”‚ .....get_invalid_issues_in_repo: Checking
      labels on '[Functionality]  make  `og:title` differ from `<title>`, so that
      third-parties which support Open Graph data import/display utilize an alternate
      non-hyphenated format'...
      
      2024-03-31 00:20:09,481 β”‚ INFO     β”‚ ......are_issue_labels_valid: Issue
      '[Functionality]  make  `og:title` differ from `<title>`, so that third-parties
      which support Open Graph data import/display utilize an alternate
      non-hyphenated format' has missing labels.
      
      2024-03-31 00:20:09,482 β”‚ SUCCESS  β”‚ .....get_invalid_issues_in_repo: done.
      
    • artifacts excerpt:
      vocabulary-theme:
      - issue: '[Functionality]  make  `og:title` differ from `<title>`, so that third-parties
          which support Open Graph data import/display utilize an alternate non-hyphenated
          format'
        reason: 'Missing labels from label groups: status'
        url: https://github.com/creativecommons/vocabulary-theme/issues/41
  • βœ… 2024-03-30 UTC: Normalize Repos #1548: Scheduled
    • log excerpt (hard wrapped with blank lines between entries for readability):
      2024-03-30 00:18:23,462 β”‚ INFO     β”‚ .....get_invalid_issues_in_repo: Checking labels on '[Functionality]  make  `og:title` differ from `<title>`, so that third-parties which support Open Graph data import/display utilize an alternate non-hyphenated format'...
      
      2024-03-30 00:18:25,141 β”‚ INFO     β”‚ ......are_issue_labels_valid: Issue '[Functionality]  make  `og:title` differ from `<title>`, so that third-parties which support Open Graph data import/display utilize an alternate non-hyphenated format' is OK.
      
      2024-03-30 00:18:25,141 β”‚ SUCCESS  β”‚ .....get_invalid_issues_in_repo: done.
      
    • artifacts excerpt:
      vocabulary-theme: []
  • ❌ 2024-03-29 UTC: Normalize Repos #1547: Scheduled
    • log excerpt (hard wrapped with blank lines between entries for readability):
      2024-03-29 00:17:18,515 β”‚ INFO     β”‚ .....get_invalid_issues_in_repo: Checking
      labels on '[Functionality]  make  `og:title` differ from `<title>`, so that
      third-parties which support Open Graph data import/display utilize an alternate
      non-hyphenated format'...
      
      2024-03-29 00:17:20,129 β”‚ INFO     β”‚ ......are_issue_labels_valid: Issue
      '[Functionality]  make  `og:title` differ from `<title>`, so that third-parties
      which support Open Graph data import/display utilize an alternate
      non-hyphenated format' has missing labels.
      
      2024-03-29 00:17:20,129 β”‚ SUCCESS  β”‚ .....get_invalid_issues_in_repo: done.
      
    • artifacts excerpt:
      - issue: '[Functionality]  make  `og:title` differ from `<title>`, so that third-parties
          which support Open Graph data import/display utilize an alternate non-hyphenated
          format'
        reason: 'Missing labels from label groups: status'
        url: https://github.com/creativecommons/vocabulary-theme/issues/41
  • βœ… 2024-03-28 UTC: Normalize Repos #1546: Scheduled
    • log excerpt (hard wrapped with blank lines between entries for readability):
      2024-03-28 00:18:18,045 β”‚ INFO     β”‚ .....get_invalid_issues_in_repo: Checking
      labels on '[Functionality] add formats and canonical url meta areas to top
      section of the `deed` and `legal code` page contexts as patch styles'...
      
      2024-03-28 00:18:18,863 β”‚ INFO     β”‚ ......are_issue_labels_valid: Issue
      '[Functionality] add formats and canonical url meta areas to top section of the
      `deed` and `legal code` page contexts as patch styles' is OK. 
      
      2024-03-28 00:18:18,864 β”‚ SUCCESS  β”‚ .....get_invalid_issues_in_repo: done.
      
    • artifacts excerpt:
      vocabulary-theme: []

Screenshots

creativecommons/vocabulary-theme#41:
Screenshot 2024-04-08 at 12 35 45

  • last entry was from 2024-04-04 17:18 PDT

Environment

GitHub Actions

Additional context

Resolution

  • I would be interested in resolving this bug.
@TimidRobot TimidRobot added 🟨 priority: medium Not blocking but should be fixed soon πŸ›  goal: fix Bug fix πŸ’» aspect: code Concerns the software code in the repository 🏁 status: ready for work Ready for work labels Apr 8, 2024
@TimidRobot TimidRobot self-assigned this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ’» aspect: code Concerns the software code in the repository πŸ›  goal: fix Bug fix 🟨 priority: medium Not blocking but should be fixed soon 🏁 status: ready for work Ready for work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant