Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Compatibility Issue with Vendor Prefixes in vocabulary.css #92

Open
1 task done
Sophiek9h opened this issue Oct 4, 2024 · 2 comments
Open
1 task done
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🧹 status: ticket work required Needs more details before it can be worked on

Comments

@Sophiek9h
Copy link
Contributor

Sophiek9h commented Oct 4, 2024

Problem

While reviewing the vocabulary.css file, I noticed that -webkit vendor prefixes are used in some cases without providing default or -moz prefixed styles for other browsers (like Firefox). This could result in inconsistent rendering and lack of compatibility across non-WebKit browsers.

Description

The issue arises due to the inconsistent use of vendor prefixes. For example, properties with -webkit prefixes should ideally have default values and -moz prefixes where necessary to ensure cross-browser compatibility. Without these, certain styles may not render correctly on browsers like Firefox.

Proposed solution:

Refactor the CSS file to include the default property, -webkit, and -moz prefixes where necessary.
Conduct browser testing to ensure the styles render correctly across major browsers.

Alternatives

An alternative approach would be to use tools like Autoprefixer to automatically handle the addition of vendor prefixes. However, manual refactoring may provide more control and help ensure that the styles are fully optimized for each browser.

Additional context

This issue could potentially lead to visual or functional inconsistencies for users on non-WebKit browsers. Ensuring that proper vendor prefixes are used would improve the reliability of the design across all browsers.

Implementation

  • I would be interested in implementing this feature.
@Sophiek9h Sophiek9h added ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🟩 priority: low Low priority and doesn't need to be rushed labels Oct 4, 2024
@possumbilities possumbilities added 🧹 status: ticket work required Needs more details before it can be worked on and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Oct 7, 2024
@possumbilities
Copy link
Contributor

Work needs to be done here, to discern which prefixes need to remain (or be removed) across various levels of browser compatibility.

Moving to: 🧹 status: ticket work required Needs more details before it can be worked on

@possumbilities possumbilities moved this from Triage to Backlog in possumbilities Oct 7, 2024
@Sophiek9h
Copy link
Contributor Author

Sophiek9h commented Oct 7, 2024

@possumbilities
see line 1367 where -webkit-appearance:none; is written without a fallback design or similar design style for Firefox browsers

also refer from line 1200 to line 1205 where designs for -webkit was specified but not for -moz
and a few other places

Except vocabulary was not designed with old browsers in mind or Firefox then these prefixes should be added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🧹 status: ticket work required Needs more details before it can be worked on
Projects
Status: Backlog
Development

No branches or pull requests

2 participants