[appsec] Chan may block if runtime error occurs

[LaurenceJJones]

Whilst debugging various things I saw there is a chance the mux handler may get blocked due to error that can occur at runtime if we return an error:

crowdsec/pkg/acquisition/modules/appsec/appsec_runner.go

Lines 335 to 339 in 49fb24c

	err := r.ProcessInBandRules(request)
	if err != nil {
	logger.Errorf("unable to process InBand rules: %s", err)
	return
	}

can create an error and return early which means:

crowdsec/pkg/acquisition/modules/appsec/appsec.go

Line 433 in 49fb24c

response := <-parsedRequest.ResponseChannel

Channel can be blocked due to never sending a response across the parsed ResponseChannel

At the current time of writing this has never been seen by anyone but it is a potential issue that can arise in future if we do not handle it properly.

[github-actions]

@LaurenceJJones: Thanks for opening an issue, it is currently awaiting triage.

In the meantime, you can:

1. Check Crowdsec Documentation to see if your issue can be self resolved.
2. You can also join our Discord.
3. Check Releases to make sure your agent is on the latest version.

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[github-actions]

@LaurenceJJones: There are no 'kind' label on this issue. You need a 'kind' label to start the triage process.

• /kind feature
• /kind enhancement
• /kind refactoring
• /kind bug
• /kind packaging

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.