Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Publish Docker for ARM platform #545

Open
3 tasks done
glefloch opened this issue Aug 28, 2024 · 5 comments · May be fixed by dbt-labs/dbt-release#138
Open
3 tasks done

[Feature] Publish Docker for ARM platform #545

glefloch opened this issue Aug 28, 2024 · 5 comments · May be fixed by dbt-labs/dbt-release#138
Labels
community A PR, or an issue with a PR, from a community member help-wanted Extra attention is needed pkg:dbt-bigquery Issue affects dbt-bigquery type:enhancement New feature request

Comments

@glefloch
Copy link

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-bigquery functionality, rather than a Big Idea better suited to a discussion

Describe the feature

The current docker image only support linux/amd64 platform. It makes it impossible to run the image on ARM

Describe alternatives you've considered

In order to test on a local Mac, I have to build the image locally.
After looking at the release script, it seems that in input parameters of the docker release script, we can easily specify target platforms (https://github.com/dbt-labs/dbt-release/blob/8e581cac0fdcf3cefc7a72736d4d71f51420d7b5/.github/workflows/release-docker.yml#L32).

Who will this benefit?

People who run M1/M2 macbook would be able to run the image locally. Also, AWS offers Graviton processors based on ARM, people running on those machine could also use it.

Are you interested in contributing this feature?

yes!

Anything else?

No response
@glefloch glefloch added type:enhancement New feature request triage:product In Product's queue labels Aug 28, 2024
@amychen1776 amychen1776 added help-wanted Extra attention is needed and removed triage:product In Product's queue labels Aug 28, 2024
@amychen1776
Copy link
Contributor

@glefloch if you feel like contributing this to the adapter, we would very much appreciate that!

@glefloch
Copy link
Author

Sure, I will try to push something!

@mikaelahlinder
Copy link

@glefloch Any update on this?

@glefloch
Copy link
Author

glefloch commented Oct 4, 2024

Yes, I have a working version on my machine, but I had to remove a package, and I'm not sure of impacts, I'm running more tests. I will try to open a draft PR ASAP

@mjdavidson
Copy link

@glefloch how did you get on with this?

@mjdavidson mjdavidson linked a pull request Nov 20, 2024 that will close this issue
Open
3 tasks
@mikealfare mikealfare added the community A PR, or an issue with a PR, from a community member label Dec 11, 2024
@mikealfare mikealfare added the pkg:dbt-bigquery Issue affects dbt-bigquery label Jan 14, 2025
@mikealfare mikealfare transferred this issue from dbt-labs/dbt-bigquery Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community A PR, or an issue with a PR, from a community member help-wanted Extra attention is needed pkg:dbt-bigquery Issue affects dbt-bigquery type:enhancement New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add linux/arm64 to docker releases mjdavidson/dbt-release
5 participants
@glefloch @mikaelahlinder @mjdavidson @mikealfare @amychen1776