fix equal_rowcount between 2 different tables #987
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add coalesce to count_a and count_b before taking absolute difference so it doesn't result as null
resolves #986
Problem
When
equal_rowcount
is applied between 2 tables of different groupby keys, the test still passes.Solution
The root problem was caused by coalesce at
diff_count
because mismatching keys could cause nulldiff_count
. Therefore coalesce should be applied where the absolute difference is taking placeChecklist