Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems to not work with a redis cluster. #33

Open
PhillippOhlandt opened this issue Feb 13, 2017 · 6 comments
Open

Seems to not work with a redis cluster. #33

PhillippOhlandt opened this issue Feb 13, 2017 · 6 comments
Labels

Comments

@PhillippOhlandt
Copy link

PhillippOhlandt commented Feb 13, 2017

Please see the issue I opened here: redis/ioredis#431

Has someone tested it on their own and can confirm that it's broken/not broken?

Just to have all the information complete, here are the relevant docker-compose services:

    redis-primary:
        image: bitnami/redis:latest
        environment:
            - REDIS_REPLICATION_MODE=master
        volumes:
            - ./_redisdata:/bitnami/redis
        restart: always

    redis-secondary:
        image: bitnami/redis:latest
        depends_on:
            - redis-primary
        environment:
            - REDIS_REPLICATION_MODE=slave
            - REDIS_MASTER_HOST=redis-primary
            - REDIS_MASTER_PORT=6379
        restart: always

And here is the DS config:

plugins:
  message:
    name: redis
    options:
      nodes:
       - host: "redis-primary"
         port: 6379
       - host: "redis-secondary"
         port: 6379
      maxRedirections: 16
      scaleReads: slave
      redisOptions:
        foo: bar # just to have an entry here, otherwise the connector will fail in another way
  cache:
    name: redis
    options:
      nodes:
       - host: "redis-primary"
         port: 6379
       - host: "redis-secondary"
         port: 6379
      maxRedirections: 16
      scaleReads: slave
      redisOptions:
        foo: bar
@PhillippOhlandt
Copy link
Author

I created a little demo project to show the failure. https://github.com/PhillippOhlandt/deepstream-redis-cluster

@yasserf yasserf added the in qa label Jul 31, 2017
@AlexBHarley AlexBHarley added ready and removed in qa labels Aug 25, 2017
@ben-auo
Copy link

ben-auo commented Oct 30, 2024

Is this still an issue or does Redis Cluster work on the latest Deepstream version?

@ben-auo
Copy link

ben-auo commented Oct 30, 2024

Just saw https://deepstream.io/blog/20200519-deepstream-maintenance-mode/

We may be on our own figuring this out.

@yasserf
Copy link
Contributor

yasserf commented Oct 31, 2024

heya!

Should be relatively simple to implement this, as it's usually just a change in the constructor.

@jaime-ez has been doing a great job maintaining the deepstream project, but if you raise a PR I'll be happy to look into it 👍

@jaime-ez
Copy link
Contributor

jaime-ez commented Nov 4, 2024

Hi, I haven't used redis with deepstream so I don´t know. Although the issue you're commenting is from before the current version.
Feel free to test and let us know if it works in order to close this issue.
Best!

@ben-auo
Copy link

ben-auo commented Nov 5, 2024

Got it. I'll actually try with Valkey instead due to the recent Redis drama. Glad to see the project is still active :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants