Skip to content
This repository has been archived by the owner on Apr 6, 2021. It is now read-only.

Login callback behaviour needs to be reviewed #120

Open
yasserf opened this issue Apr 14, 2017 · 1 comment
Open

Login callback behaviour needs to be reviewed #120

yasserf opened this issue Apr 14, 2017 · 1 comment

Comments

@yasserf
Copy link
Contributor

yasserf commented Apr 14, 2017

We need to review the login behaviour in deepstream in general. Having a login callback being called more than once should be invalid behaviour

@jdmnd
Copy link
Contributor

jdmnd commented Apr 18, 2017

proposed new method signature:

login(auth_data
login_callback // (success) => ..., 
client_data_received_callback // (client_data) => ...
)

login_callback is called exactly once, when auth succeeds or fails. it is destructed thereafter
client_data_received_callback is called once if auth succeeds and again whenever there is a transition AUTHENTICATING -> OPEN

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants