improve sharing large images #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extensions must not use more than 120mb of memory, this is easily exhausted by core scaling down images. using iOS function for scaling use less memory (or the memory is not counted) and avoids this error. although we accept various formats of images, in practise i've seen them passing to the extension only as URL, if we see that for other formats as well, we can optimize the other branches, currently, that seems not to be needed.
adbenitez
approved these changes
Dec 15, 2023
Simon-Laux
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the reason that sharing (mostly) panoramas does not work is that they are pretty large - sth. as 16382 x 3690 pixels, needing 180+ mb pixel data in core before recoding - where extensions are limited to 120 mb by iOS.
this PR uses UI to scale images to "1280 pixels max width or height", so that scaling in core should not be needed most times. scaling in UI consumes less memory - or that memory is not counted to the 120 mb.
closes #1330
closes deltachat/deltachat-core-rust#2681