Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub and GitLab notifications are received as read-only mailing lists and cannot be replied to #3708

Open
anaskaejdar opened this issue Oct 29, 2022 · 5 comments

Comments

@anaskaejdar
Copy link

  • Android version: 12

  • Device: Samsung GS20

  • Delta Chat version: 1.34.2

  • Expected behavior: At least the ability to toggle a thread's designation as channel, in case DL/DC got it wrong.

  • Actual behavior: Some github and gitlab notifications, though not all (seems arbitrary), are received by DL/DC as channels, thus witholding my ability to reply. Github/gitlab notification threads, however, are supposed to allow replies: it says so right in the email.

  • Steps to reproduce the problem: I don't know. How do you determine a thread to be a channel, anyway?

  • Screenshots:
    Screenshot_۲۰۲۲۱۰۲۹-۱۱۱۲۰۹_DeltaLab
    Screenshot_۲۰۲۲۱۰۲۹-۱۱۱۴۴۱_DeltaLab

  • Logs:

@adbenitez
Copy link
Member

@anaskaejdar, please, don't report DeltaLab issues here, only report here stuff you have tested on the official app, deltalab issues should go to https://github.com/adbenitez/deltalab-android/issues

in this case the issue is that Delta Chat doesn't support replies in that github mailing lists because it is message-based and don't have a List-Post header, deltalab displays "channels" for mailing list you don't have write access and "super group" to discussion mailing lists, instead of "mailing list" that is shown by official client, both apps don't support writing to GitHub threads at the moment

@link2xt
Copy link
Collaborator

link2xt commented Nov 1, 2022

Except for terminology (channel vs mailing list), having an option to reply to GitHub threads would be nice.

@link2xt link2xt transferred this issue from deltachat/deltachat-android Nov 1, 2022
@anaskaejdar
Copy link
Author

I apologize for the terminology. I didn't know what would be the preferred terminology in english, because DC translates it — both channels and supergroups are called «لیست ایمیل» for me in DC. But DL doesn't translate them, so I see them called “channel” and “supergroup.”

Tangentially: I see DC has transifex. Does DL also have one?

@adbenitez
Copy link
Member

Tangentially: I see DC has transifex. Does DL also have one?

no, but you can create a Pull Request in the DeltaLab repo editing the corresponding res/values-LANG/string.xml file adding the missing values from res/values/strings.xml

@link2xt link2xt changed the title Threads misidentified as channels GitHub and GitLab notifications are received as read-only mailing lists and cannot be replied to Jul 25, 2023
@adbenitez
Copy link
Member

Except for terminology (channel vs mailing list), having an option to reply to GitHub threads would be nice.

wouldn't the "reply privately" option not work in that case?? looks like it should out of the box unless we are doing something wrong in the "reply privately" implementation, it is a quote-reply to a message and should be similar to when the user click the reply button, maybe the mail subject is the problem, DC should put Re: ORIGINAL-SUBJECT as usual

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants