Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send backup: fail quickly on insufficient storage #4200

Closed
Tracked by #4180
r10s opened this issue Mar 21, 2023 · 3 comments
Closed
Tracked by #4180

send backup: fail quickly on insufficient storage #4200

r10s opened this issue Mar 21, 2023 · 3 comments
Labels
backup Backup transfer and 2nd device setup discussion

Comments

@r10s
Copy link
Member

r10s commented Mar 21, 2023

receiving a large backup can take several dozen minutes - if, at 90%, the device is out of storage, this is very frustrating - not only that the backup did not succeed, also much time was wasted.

this issue is especially true for low-budget devices, which have poor transfer rates due to poor wi-fi hardware - and often little storage space as well. plus, there may be an overall poor network, bad router, far away from router ...

my suggestion is that dc_receive_backup() returns as soon as possible if it is clear that there is insufficient storage, with a nice error set (so no UI adaptions are needed).

my first idea was to add the storage needed to the qr code, however, @dignifiedquire pointed out in the Dev chat that additional information in the qr code are not needed, iroh already knows the size, so it’s a matter of figuring out what to do with that info.

while being a huge UX improvement, much more than "nice to have", this issue is still an optimisation, so i would not see that as absolutely necessary for a first release. depends a bit on how hard it is to do :)

@r10s r10s mentioned this issue Mar 21, 2023
25 tasks
@flub
Copy link
Member

flub commented Mar 22, 2023

iroh already sends over a size hint of the total size being sent over. That is only once the transfer is started, so you need to establish the connection first. But there is a callback that the receiving device can hook into and do something right at the start of the transfer, before it starts pulling in all the data. And it can decide to abort at that point.

@link2xt
Copy link
Collaborator

link2xt commented Jul 25, 2023

Related issue about insufficient storage: #4307

@flub flub added the backup Backup transfer and 2nd device setup label Jul 25, 2023
@r10s
Copy link
Member Author

r10s commented Nov 10, 2024

closing stale issue discussion

@r10s r10s closed this as not planned Won't fix, can't repro, duplicate, stale Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backup Backup transfer and 2nd device setup discussion
Projects
None yet
Development

No branches or pull requests

3 participants