Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Garbage-collect unused hidden contacts during housekeeping #4775

Closed
link2xt opened this issue Oct 2, 2023 · 1 comment
Closed

Garbage-collect unused hidden contacts during housekeeping #4775

link2xt opened this issue Oct 2, 2023 · 1 comment

Comments

@link2xt
Copy link
Collaborator

link2xt commented Oct 2, 2023

Contacts are just hidden since #3751 if they have references. However, once there are no references, it should be possible to garbage-collect the contact.

This needs a test adding a contact, creating a chat, deleting (hinding) a contact, then deleting a chat and calling housekeeping, then checking that the contact gets actually removed.
@Septias Septias mentioned this issue Oct 4, 2023
Closed
@link2xt
Copy link
Collaborator Author

link2xt commented Oct 5, 2023

There is an unmerged PR #4791 (replacing attempts #4785 and #4790).

Let's move any further contact deletion discussion to #4792.

@link2xt link2xt closed this as not planned Won't fix, can't repro, duplicate, stale Oct 5, 2023
@link2xt link2xt mentioned this issue Oct 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Delete hidden contacts in housekeeping deltachat/deltachat-core-rust
1 participant
@link2xt