Do not try to start I/O before deleting account

[link2xt]

Currently if an account is imported from Android nightly or DeltaLab (now ArcaneChat) into the current Desktop with stable core 1.142.11, it fails to start I/O with a toast "Failed to start I/O: Invalid configured_imap_certificate_checks value". This is expected, user will need to update to the new core or reconfigure an account to make it usable.

The problem is that it is impossible to delete such broken account in the current Desktop 1.46.7. When user right-clicks the profile and selects "Delete Profile", desktop calls selectAccount here:

deltachat-desktop/src/renderer/ScreenController.tsx

Line 189 in 9fdd6ea

await this.selectAccount(accountId)

selectAccount is this function that tries to start I/O and fails:

deltachat-desktop/src/renderer/ScreenController.tsx

Lines 119 to 142 in 9fdd6ea

	async selectAccount(accountId: number) {
	if (accountId !== this.selectedAccountId) {
	await this.unSelectAccount()
	this.selectedAccountId = accountId
	;(window.__selectedAccountId as number) = accountId
	} else {
	log.info('account is already selected')
	// do not return here as this can be the state transition between unconfigured to configured
	}
	const account = await BackendRemote.rpc.getAccountInfo(
	this.selectedAccountId
	)
	if (account.kind === 'Configured') {
	this.changeScreen(Screens.Main)
	} else {
	this.changeScreen(Screens.Welcome)
	}
	await BackendRemote.rpc.startIo(accountId)
	runtime.setDesktopSetting('lastAccount', accountId)
	log.info('system_info', await BackendRemote.rpc.getSystemInfo())
	log.info('account_info', await BackendRemote.rpc.getInfo(accountId))
	}

Desktop should not try to start I/O before deleting an account. If it fails, account cannot be deleted. Also if advanced setting "Only Synchronize Selected Profile" is enabled, I/O may have been stopped on purpose and starting I/O right before deleting an account is unnecessary.

[Simon-Laux]

So solution could be to add an argument to skip startIo and then from the delete screen call it with that argument?

Or simpler just omit the await or put it inside of a try/catch block to ignore the error? first one is better because of:

Also if advanced setting "Only Synchronize Selected Profile" is enabled, I/O may have been stopped on purpose and starting I/O right before deleting an account is unnecessary.

Why isstartIo part of selectAccount(id) in the first place?
Because there is a setting ("Only Synchronize Selected Profile") to restore the old behaviour of desktop where only the selected account is connected.
This is useful for some people that need more control about what accounts connect in public networks.
I started a pr to make core handle it instead of UI code in desktop a while ago: deltachat/deltachat-core-rust#5314

[adbenitez]

This is useful for some people that need more control about what accounts connect in public networks.

for this in ArcaneChat we have ui.enabled and allow users to enable/disable accounts individually, that is more flexible than "enable selected account only" since then you can use ex. 2-3 needed accounts concurrently while the rest are disabled

[Simon-Laux]

that is more flexible than "enable selected account only" since then you can use ex. 2-3 needed accounts concurrently while the rest are disabled

thats also what the core pr does. But there is still the usability question whether account should be started automatically when it is selected despite being disabled or if it should just stay disabled until the user enables it again.

[adbenitez]

it should stay disabled, and a banner could be shown at the top saying "The profile is disabled [ENABLE]" ot so

similar to what Conversations(xmpp) does for disabled accounts