-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sharing panoramas not working #1330
Comments
same is true for videos shared from the gallery to delta EDIT: i created a separate issue for that, #2021 |
the debugger shows the exception thrown is: the exception indicates that too much memory is used, probably in the method findWriterForTypeAndAlternateType (core?). |
The same spike in memory consumption (only for processing the image ~250 mb) appears if I send a panorama image by attaching them in a chat. The only difference is that there's no hard memory limitation of 120 mb in our main app. That's why sending panorama images from the app works while sending them from the extension doesn't. I have 3 proposals how to improve the current situation:
|
but there should be at least a correct error message - that is where i would begin with.
|
it's impossible to do any error handling after a jpg of 9.5mb already consumes 285mb internal memory while |
can you tell the pixel dimensions of that image? 250mb for recoding in core is a lot, but may still be reasonable somehow. what about the .heic format - is that an issue as well? |
the example image has the dimensions 8390 × 3780 |
thanks - that should be about 126mb raw (assuming 4 bytes/pixel) - so the 250mb needed for recoding in core seems reasonable - and we can assume there is not really a core issue wrt wasting memory.
that is done in ios
internally = core-sided then? |
@cyBerta can you measure the memory consumption for a smaller image that does not fail? as suggested at deltachat/deltachat-core-rust#2681 (comment)? |
right
I mean the share extension in this case. The share extensions recognizes and handles the image as jpeg. the jpeg image data size of this image in the memory of the share extension was ~30-35 MB. |
i just retried with a more recent iphone13: the "share dialog" appears, however, sharing does not succeed and there is also no error message; i edited the initial post to these new findings. minimal thing to close this issue would be an error message. |
sharing a panorama to delta chat does not work - the panorama is not shared, and the share-to dialog does not disappear (tested 2021 on iphone7 with ios 14.7.1) or the share-to-dialog appears but sharing fails then (tested 2023 on iphone13 with ios 16.1.2). sharing normal photos to delta chat works as expected.
The text was updated successfully, but these errors were encountered: