Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TooltipButton 컴포넌트 리팩토링 #324

Open
sumi-0011 opened this issue Jun 18, 2023 · 0 comments
Open

TooltipButton 컴포넌트 리팩토링 #324

sumi-0011 opened this issue Jun 18, 2023 · 0 comments
Assignees
Labels
refactor Refactoring something

Comments

@sumi-0011
Copy link
Member

설명

#323 (comment)
뭔가 파일명이 버튼을 렌더링할 거 같은 느낌처럼 저는 느껴지는데,

하는 일은 children위에 툴팁을 렌더링하는 거 같아요

이름을 바꿔도 좋을 거 같고,

WithTooltip 처럼 HOC를 사용하는 방법 혹은 CTAButton의 props로 주입해서 버튼도 같이 렌더링하는 방법으로 나타낼 수도 있을 거 같아요!

@sumi-0011 sumi-0011 added the refactor Refactoring something label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring something
Projects
Status: Todo
Development

No branches or pull requests

1 participant