-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate out non-CDK related code #30
Comments
Actually this looks like a (partial?) duplicate of #4. |
@emileten Our approach for building APIs has largely focused on building FastAPI applications. One of their great advantages is the simplicity of having route logic defined internally in the application but still being able to support several different deployment targets, but this does require a some very thin mangum wrapping to support application deployment for the API Gateway/Lambda context. The goal of of this As @alukach was building out the We will always some level of wrapping code that ties our deployment context (Lambda) and configuration to our FastAPI apps so having https://github.com/developmentseed/cdk-pgstac/tree/main/lib/stac-api/runtime will always be a necessity to simple things for construct users. We'll use the same pattern as we incorporate https://github.com/stac-utils/titiler-pgstac into |
Thanks for the reply @sharkinsspatial, I understand the logic and agree that
is the piece that should be moved. |
from the title in the README,
cdk-pgstac
is a set of AWS CDK constructs that spin up AWS infrastructure to operate and use apgstac
database.As such, any application it relies on shouldn't be defined in
cdk-pgstac
, but only used as an external dependency, so thatcdk-pgstac
focuses only on AWS CDK logic.From that perspective, the following application code that currently is located in this repository should be separated out :
ingestor-api
stac-api
.I think @alukach already mentioned (1) in a previous call. Does this make sense to you ?
The text was updated successfully, but these errors were encountered: