Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move templates from rice to packr #136

Open
2 tasks
mattstratton opened this issue Nov 1, 2019 · 3 comments
Open
2 tasks

Move templates from rice to packr #136

mattstratton opened this issue Nov 1, 2019 · 3 comments
Labels
Status: Ready Issues that are ready for someone to work on Type: Enhancement

Comments

@mattstratton
Copy link
Member

mattstratton commented Nov 1, 2019

When changes are made to the event templates, they need to be recompiled. Right now that is only documented in source code at https://github.com/devopsdays/devopsdays-cli/blob/master/event/make_event_files.go#L23

	// to compile, cd to event directory and run `rice embed-go`

That's probably not amazing.

The idea is to migrate from using rice to instead use packr.

There are two main things that need to be done:

@mattstratton
Copy link
Member Author

@chriscoffee we might use this issue for the template re-working if you want to switch from rice; let me know and I can update the issue :)

@mattstratton
Copy link
Member Author

If you look at #121 apparently, that's the ticket where I moved a bunch of stuff out of rice and put it into the .go files directly.

I'm going to rename this issue to be more about using packr instead - note that this will change how we release. The upshot of packr is that while doing local development, there is no need to run any commands to compile the templates; it is just something that happens at build time, so the build commands will need to be updated.

@mattstratton mattstratton changed the title Document updating of rice templates Move templates from rice to packr Nov 2, 2019
@mattstratton mattstratton added Status: Ready Issues that are ready for someone to work on Type: Enhancement and removed Status: Accepted labels Nov 2, 2019
@mattstratton
Copy link
Member Author

mattstratton commented Nov 6, 2019

Of course, Mark Bates just announced a replacement for packr:
https://blog.gobuffalo.io/introducing-pkger-static-file-embedding-in-go-1ce76dc79c65

Medium
One of the reasons I fell in love with Go all those years ago was the idea that I could distribute a single binary that only contained my…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Ready Issues that are ready for someone to work on Type: Enhancement
Projects
None yet
Development

No branches or pull requests

1 participant