Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings Subsystem: Settings have to be manually added to the project settings #2494

Open
Jowan-Spooner opened this issue Dec 17, 2024 · 1 comment
Labels
Bug 🐞 Something isn't working

Comments

@Jowan-Spooner
Copy link
Member

The problem

Not sure how this happened, but right now it's not possible to simply use a setting like text_speed in a fresh project. It won't save (or more correctly it won't load). The only fix is to manually add the text_speed setting to the project settings. This is not documented and not the intuitive approach that we originally intended. So this should be fixed, probably by having dialogic automatically create these settings when enabled.

@Jowan-Spooner Jowan-Spooner added the Bug 🐞 Something isn't working label Dec 17, 2024
@jrb0001
Copy link
Contributor

jrb0001 commented Dec 31, 2024

I just encountered this bug too.

The setting is correctly saved to global_info.txt but when loading, the settings subsystem iterates through all project settings and then overwrites the value with one loaded from global_info.txt. This is also very inefficient because the save subsystem loads and parses the file once per setting.

Additionally the settings subsystem reloads all settings on every clear() which won't have any effect after this bug is fixed as long as the save subsystem exists. I thought the settings subsytem is meant for global configuration? If so, then it should never be cleared/reloaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Something isn't working
Development

No branches or pull requests

2 participants