Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scene queries squawk when pipelines are disabled #213

Open
ndarilek opened this issue Jul 13, 2022 · 1 comment
Open

Make scene queries squawk when pipelines are disabled #213

ndarilek opened this issue Jul 13, 2022 · 1 comment
Labels
A-Integration very bevy specific C-Enhancement New feature or request D-Medium P-Medium S-not-started Work has not started

Comments

@ndarilek
Copy link
Contributor

I spent a long time debugging a situation where I'd turned off physics/query pipelines to spawn everything in a level, tried to move a system that needed the pipeline into that spawning state, and suddenly found my pipeline queries not returning objects they should have. Once I realized my mistake, the solution was obvious. But it took longer than it should have to get to that realization.

Could various QueryPipeline functions possibly log an error, panic, etc. if called when the physics pipeline is disabled? I don't think I care which they do--I just didn't remember that I'd disabled physics for legitimate reasons, and would have appreciated it if the scene queries I'd ran had at least told me they wouldn't do anything, even if only in debug builds.

Not sure if this should be in bevy_rapier or lower in the stack.

Thanks.

@sebcrozet
Copy link
Member

Hi! I agree that we could add some warning. A warn log sounds appropriate here instead of a panic.

Not sure if this should be in bevy_rapier or lower in the stack.

Yes, this should be in bevy_rapier.

@Vrixyz Vrixyz added C-Enhancement New feature or request D-Medium P-Medium S-not-started Work has not started A-Integration very bevy specific labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Integration very bevy specific C-Enhancement New feature or request D-Medium P-Medium S-not-started Work has not started
Projects
None yet
Development

No branches or pull requests

3 participants