Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KinematicCharacterController climbing and sliding along along vertical walls are broken #611

Closed
cleak opened this issue Mar 31, 2024 · 0 comments · Fixed by #627
Closed

Comments

@cleak
Copy link

cleak commented Mar 31, 2024

I opened an issue over on bevy_rapier, but since the fix is in this repo, I'm opening an issue here as well.

It looks like slope climbing is completely broken due to the check with self.max_slope_climb_angle being reversed. I haven't tried this on any actual slopes, but this breaks movement along vertical and near vertical walls.

if climbing && angle_with_floor >= self.max_slope_climb_angle {
    // Prevent horizontal movement from pushing through the slope.
    vertical_translation
} else if !climbing && angle_with_floor <= self.min_slope_slide_angle {

the fix is simple at least:

if climbing && angle_with_floor <= self.max_slope_climb_angle {

I'll submit a PR.

@cleak cleak changed the title KinematicChracterController climbing and sliding along along vertical walls are broken KinematicCharacterController climbing and sliding along along vertical walls are broken Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant