Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreateCategoryAsync naming inconsistency #1262

Open
Still34 opened this issue Feb 8, 2019 · 0 comments · May be fixed by #1269
Open

CreateCategoryAsync naming inconsistency #1262

Still34 opened this issue Feb 8, 2019 · 0 comments · May be fixed by #1269
Labels
on hold version: major

Comments

@Still34
Copy link
Member

Still34 commented Feb 8, 2019

Summary

In the current design (2.x), CreateCategoryAsync under the interface IGuild should be renamed to CreateCategoryChannelAsync for better naming consistency, as this is the naming for the rest of the CreateXChannelAsync methods and is the name at the implementation level of such method (e.g. SocketGuild#CreateCategoryChannelAsync.

Due to the breaking nature of renaming the API/method, this is considered a 3.0 candidate.
Chris-Johnston added a commit to Chris-Johnston/Discord.Net that referenced this issue Feb 19, 2019
@Chris-Johnston
Fix discord-net#1262 Rename CreateCategoryAsync to CreateCategoryChan…
04d46ec 
…nelAsync

Renames CreateCategoryAsync to CreateCategoryChannelAsync so that it is more
consistent with the naming with the naming of other channel creation
methods.
@Chris-Johnston Chris-Johnston linked a pull request Feb 19, 2019 that will close this issue
Open
@quinchs quinchs linked a pull request Feb 3, 2022 that will close this issue
Fix #1262 Rename CreateCategoryAsync to CreateCategoryChannelAsync #1269
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
on hold version: major
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1262 Rename CreateCategoryAsync to CreateCategoryChannelAsync Chris-Johnston/Discord.Net
1 participant
@Still34