Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Custom CSS Classes in Stylesheets > Tailwind Classes #772

Open
1 of 7 tasks
jtfairbank opened this issue Oct 17, 2022 · 6 comments · Fixed by #834
Open
1 of 7 tasks

Refactor Custom CSS Classes in Stylesheets > Tailwind Classes #772

jtfairbank opened this issue Oct 17, 2022 · 6 comments · Fixed by #834
Assignees
Labels
good first issue Good for newcomers hacktoberfest Refactor Cleanup part of the codebase without changing functionality

Comments

@jtfairbank
Copy link
Contributor

jtfairbank commented Oct 17, 2022

Description

Our site has some legacy code that uses CSS classes to style some pages / components in /src/stylesheets/. Since then we've adopted Tailwind as our main styling library. It'd be helpful to refactor these stylesheets so the pages / components use Tailwind instead, OR add a comment at the top of the stylesheet to highlight why CSS classes are a better solution for that particular page. Some of the CSS classes may simply be unused, in which case they can be removed.

CodeSee map of relevant files / folders.

Front end feature screenshots

There should be minimal changes to the front-end look / feel / content of the site. This is more of a maintenance refactoring.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Checklist

  • Add your name to /CONTRIBUTORS.md if you're a first-time contributor!
  • Refactor /src/stylesheets/burger.css
  • Refactor /src/stylesheets/nav.css - @TylerGeorgeAlexander
  • Refactor /src/stylesheets/routes.css - @linds0202
  • Refactor /src/stylesheets/timeline.css - @homiecoder
  • Refactor /src/stylesheets/index.css
@jtfairbank jtfairbank added good first issue Good for newcomers hacktoberfest Refactor Cleanup part of the codebase without changing functionality triage An issue needs further analysis by a team member labels Oct 17, 2022
@20RitikSingh
Copy link

I want to work on this.

@jtfairbank jtfairbank removed the triage An issue needs further analysis by a team member label Oct 17, 2022
@jtfairbank
Copy link
Contributor Author

Sounds great @20RitikSingh! I've assigned you to the issue. If you need any help, do checkout our #Hacktober event schedule.

I'd recommend taking it 1 stylesheet at a time and getting that first pull request / draft up sooner rather than later so it's easy to collaborate. 😄

This was referenced Oct 17, 2022
@jtfairbank
Copy link
Contributor Author

jtfairbank commented Oct 31, 2022

Hey @20RitikSingh how's this one coming along? If you need any help @RabeaGleissner or @linds0202 might be interested in contributing here. They just did a great job on #777 which is related to this one!

@linds0202 linds0202 self-assigned this Nov 2, 2022
@linds0202
Copy link
Contributor

If @20RitikSingh doesn't mind, I am going to finish the refactoring for the routes stylesheet

@TylerGeorgeAlexander
Copy link
Contributor

Hey, I'd like to work on the nav.css

@jtfairbank
Copy link
Contributor Author

Sorry, not sure why this was closed.

@20RitikSingh 20RitikSingh removed their assignment Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Refactor Cleanup part of the codebase without changing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants