Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for kibana 7.6.X #83

Open
pchakour opened this issue Mar 24, 2020 · 8 comments
Open

Support for kibana 7.6.X #83

pchakour opened this issue Mar 24, 2020 · 8 comments

Comments

@pchakour
Copy link

pchakour commented Mar 24, 2020

Hello everyone :)

I make the migration of the plugin for kibana 7.6.X. Feel free to use it or not.
This is the zip containing the patch : kbn_network_7.6.X.zip

The patch include:

  • The migration for kibana 7.6.X
  • Remove the background option to have the dashboard background (usefull to switch between light and dark mode)
  • Fix some Eslint issues
  • The update of the vis-network library

To apply it, you have to :

  • clone the plugin
  • checkout the commit a4a1cdb of the branch 7-dev
  • unzip the patch
  • use this command to apply the patch : git am --signoff -k < PATCH_PATH

    Replace PATCH_PATH with the path of the patch

  • execute the yarn command
  • start kibana (remove the content of the optimize directory before if you are not in dev mode)
@ranayayas
Copy link

Hi ,

tks for the patch. I try to implement it, however not sure if I do the right way.
Is the clone etc is performed in home folder or kibana folder?
Can you give example of the command being used especially for the yarn

Tks

@pchakour
Copy link
Author

pchakour commented Mar 26, 2020

Hi,

you have to clone the repository in the plugins directory that you can found in the kibana folder.
If the plugins directory doesn't exist, create it...

This is the list of command to do, inside the plugins directory:

  • git clone https://github.com/dlumbrer/kbn_network.git
  • cd kbn_network
  • git checkout a4a1cdb
  • git am --signoff -k < PATCH_PATH
  • yarn install

@ranayayas
Copy link

It works, tks.
In my case, I have to do
yarn --ignore-engines install

@maintain3r
Copy link

Hi pchakour,
I try to use it with Kibana 7.6.2 and Elastiflow 4-beta-1 and it fails. The patch proposed above works with only when kibana-7.6.2 + elastiflow-3.5.2.
Thank you.

@Malwar3Ninja
Copy link

Malwar3Ninja commented Apr 24, 2020

Any update on this? Is the updated version released for 7.6.2 ?

@cpiment
Copy link

cpiment commented May 13, 2020

This is the list of command to do, inside the plugins directory:

  • git clone https://github.com/dlumbrer/kbn_network.git
  • cd kbn_network
  • git checkout a4a1cdb
  • git am --signoff -k < PATCH_PATH
  • yarn install

Thanks for your patch! I tried it and almost got me there, but I had to modify the package.json to make it work in Kibana 7.6.2

$ git diff package.json
diff --git a/package.json b/package.json
index 7c3b64b..770c029 100644
--- a/package.json
+++ b/package.json
@@ -1,9 +1,6 @@
 {
   "name": "network_vis",
-  "version": "7.5.2",
-  "kibana": {
-    "version": "kibana"
-  },
+  "version": "7.6.2",
   "authors": [
     "David Moreno Lumbreras <[email protected]>"
   ],
@@ -17,7 +14,7 @@
     "randomcolor": "^0.5.0",
     "keycharm": "^0.2.0",
     "moment": "^2.24.0",
-    "vis-data": "^6.2.1",
+    "vis-data": "^6.5.1",
     "vis-util": "^1.1.8"
   }
 }

I removed the "kibana" node of the package.json and updated the vis-data version to 6.5.1. With this changes I did an npm install instead of yarn install and zipped the plugin and installed it with kibana-plugin install.

@dlumbrer do you want a PR with this changes? The patch of @pchakour and my changes to package.json

@dlumbrer
Copy link
Owner

@dlumbrer do you want a PR with this changes? The patch of @pchakour and my changes to package.json

That would be awesome! Please, submit a PR to the 7-dev branch

@cpiment
Copy link

cpiment commented May 14, 2020

Submitted #85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants