Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose devnet endpoints #1586

Open
notV4l opened this issue Feb 26, 2024 · 10 comments · May be fixed by #2490
Open

Expose devnet endpoints #1586

notV4l opened this issue Feb 26, 2024 · 10 comments · May be fixed by #2490
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers katana This issue is related to Katana

Comments

@notV4l
Copy link
Collaborator

notV4l commented Feb 26, 2024

Is your feature request related to a problem? Please describe.
To support argentX & braavos, katana should expose some http endpoints.

Describe the solution you'd like
support /predeployed_accounts (GET)
support /account_balance (GET)
support /fee_token (GET)
support /mint (POST)

Additional context
Im not sure which of those methods are required/used.
After testing some, /predeployed_accounts is called, but those accounts are not used
Seems both argentX & braavos deploy there own accounts and fund it using /mint

the way tis handled in starknet-devnet-rs
https://github.com/0xSpaceShard/starknet-devnet-rs/blob/e3c69015fa19f261487ea094caee2c72cdc3a64b/crates/starknet-devnet-server/src/server.rs#L44-L47

@notV4l notV4l added enhancement New feature or request katana This issue is related to Katana labels Feb 26, 2024
@glihm glihm changed the title [katana] Expose devnet endpoints Expose devnet endpoints Jun 19, 2024
@glihm
Copy link
Collaborator

glihm commented Jun 19, 2024

That may actually be a good first issue, as the necessary implementations and types are here, and this should be placed under the dev RPC namespace of Katana: https://github.com/dojoengine/dojo/blob/main/crates/katana/rpc/rpc-api/src/dev.rs.

@glihm glihm unassigned kariy Jun 19, 2024
@glihm glihm added the good first issue Good for newcomers label Jun 19, 2024
@PedroRosalba
Copy link

@notV4l @glihm Can I work on this task?

@fabrobles92
Copy link
Contributor

Hello @glihm I would like to work on this issue :D

@glihm
Copy link
Collaborator

glihm commented Jul 10, 2024

Sorry guys for the delay on this one. @PedroRosalba if you're still around, please let's know. If not, @fabrobles92 will be assigned to you. 👍

@glihm
Copy link
Collaborator

glihm commented Jul 17, 2024

@fabrobles92, all yours!

@fabrobles92
Copy link
Contributor

fabrobles92 commented Jul 20, 2024

@glihm I am looking into this now and want to make sure I understand correctly what is needed here.

I have to add the following methods to the trait DevApi here:
predeployed_accounts
account_balance
fee_token
mint

Note.
I am seeing that under crates/katana/rpc/rpc-api/src/katana.rs we already have a trait method called predeployed_accounts

Note 2.
You mention that the necessary implementations and types are already in the code, I am trying to find them without luck, would you point me where are those?

Or I need to create a new endpoint somewhere with those routes?

@glihm
Copy link
Collaborator

glihm commented Aug 12, 2024

Sorry @fabrobles92 I just totally missed that. Could we catch up during the week?

That's perfect under Dev api. 👍
@kariy do you confirm or should we do an other namespace for those RPC calls?

@glihm
Copy link
Collaborator

glihm commented Aug 29, 2024

Any update on that @fabrobles92?

@fabrobles92
Copy link
Contributor

Currently looking into the implementations and types that already exist in code.

@bigherc18
Copy link

If this is still open, I'd like to step in

I was an early contributor to the Starknet community. After being disconnected for a few months, I’m eager to get back on track, and I’d like to work on this issue as a way to re-engage and contribute actively again.

Aside from that, I’m passionate about seeing Web3 gaming thrive, and I believe Dojo is the best project to make that vision a reality.

@fabrobles92 fabrobles92 linked a pull request Jan 3, 2025 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers katana This issue is related to Katana
Projects
No open projects
Status: No status
Development

Successfully merging a pull request may close this issue.

6 participants