Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minDate/maxDate parsing error #13

Open
robin-thoni opened this issue Jul 1, 2017 · 1 comment
Open

minDate/maxDate parsing error #13

robin-thoni opened this issue Jul 1, 2017 · 1 comment
Labels

Comments

@robin-thoni
Copy link

The date format seems to be ignored when passing minDate/maxDate as string instead of date object:

selection_002
selection_003

The date format is DD-MM-YYYY, but the date is parsed as MM-DD-YYYY.

To reproduce:
Change the following in demo/index.html

@@ -151,8 +151,8 @@
         <mdp-date-picker
                 ng-model="custom.date3"
                 mdp-placeholder="{{ custom.datePlaceholder3 }}"
-                mdp-min-date="custom.minDate3"
-                mdp-max-date="custom.maxDate3"
+                mdp-min-date="custom.minDateStr3"
+                mdp-max-date="custom.maxDateStr3"
                 mdp-ok-label="{{ custom.okLabel3 }}"
                 mdp-cancel-label="{{ custom.cancelLabel3 }}"
                 mdp-date-filter="custom.dateFilter3"

The minTime/maxTime parsing seems to be okay

@dpoetzsch dpoetzsch added the bug label Jul 4, 2017
@dpoetzsch
Copy link
Owner

Confirmed. I think this is because when the dialog is called we don't convert the min / max dates to dates but haven't checked yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants