Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Picker Suggestions #24

Open
ghost opened this issue Aug 14, 2017 · 4 comments
Open

Time Picker Suggestions #24

ghost opened this issue Aug 14, 2017 · 4 comments

Comments

@ghost
Copy link

ghost commented Aug 14, 2017

I love the date picker, but I think the time picker could use a few updates.

  1. The circle on the hand of clock is partially blocked by what looks like some padding.
  2. The moment of the hand is very laggy and slow. Sometimes gets stuck when focus is lost.
  3. Dragging the hour hand should auto start the minute selection, not just clicking the value.
  4. Lastly is there a way to flex both the date and time pickers to their current layouts?

image

@dpoetzsch
Copy link
Owner

Hi there, thank you for your input.

At the moment I'm personally quite busy, but I'm happy to review pull requests for points 1-3.

Concerning point 4: What exactly do you mean by flexing the pickers to their current layouts?

@ghost
Copy link
Author

ghost commented Aug 14, 2017

Essentially, the use of the flex directive in row layouts don't really work. Below is an snapshot of a form. All the elements use flex and are properly aligned with one another. As for pull requests, unfortunately I'm not really a front-end developer myself so I don't really think I can really contribute much. I think this last issue is of the most importance, however.

image

@ghost
Copy link
Author

ghost commented Aug 15, 2017

Does that make sense? I just trying to get the line for the date entry to stretch like the other fields.

@dpoetzsch
Copy link
Owner

issue #25 extracts the issue with the flex behavior (point 4). PR #26 suggests a solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant