Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dark theme #29

Open
omar10594 opened this issue Nov 14, 2017 · 2 comments · Fixed by #30
Open

Support dark theme #29

omar10594 opened this issue Nov 14, 2017 · 2 comments · Fixed by #30

Comments

@omar10594
Copy link

Codepen with dark theme: https://codepen.io/omar10594/pen/VrWQRv

Material design guidelines:
screen shot 2017-11-13 at 6 54 53 pm
screen shot 2017-11-13 at 6 54 46 pm

At least the numbers on date picker should be white:
screen shot 2017-11-13 at 6 52 22 pm
@dpoetzsch
Copy link
Owner

I will probably not have time this month for this. But I'd be happy to review a pull request

@omar10594 omar10594 mentioned this issue Nov 21, 2017
Merged
dpoetzsch pushed a commit that referenced this issue Nov 25, 2017
Merge pull request #30 from NutriconsultorOnline/fix/dark-theme-style
04ca503 
Awesome, thanks.

I will leave #29 open for now, as we're still not fully supporting the material guidelines.
@dpoetzsch
Copy link
Owner

dpoetzsch commented Nov 25, 2017 •
edited
Loading

It is better now, since pull request #30, but still not perfect.

I just release the new version 1.1.1 that contains the fix :)

@dpoetzsch dpoetzsch reopened this Nov 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(style): Better style when the current theme is dark. NutriconsultorOnline/md-pickers
2 participants
@dpoetzsch @omar10594