Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISO String date not reconized? #36

Open
laguiz opened this issue Apr 30, 2018 · 2 comments
Open

ISO String date not reconized? #36

laguiz opened this issue Apr 30, 2018 · 2 comments

Comments

@laguiz
Copy link

laguiz commented Apr 30, 2018

Hi,

I got some issues with dates that were formatted as ISO String.

I'm running angularjs version 1.6.7.

You may want to look at this commit and see if you can take it back? laguiz@d58f048

Change is not a big deal but I'm not sure it fit the original idea.

Basic idea is to avoid to use angular.isDate() and try to parse with moment() to see if String is correct (eg: ISO String date).

Ideally I will drop this fork if you can take this back.

@dpoetzsch
Copy link
Owner

looks good to me.

If you create a clean pull request containing only the relevant changes to mdpDatePicker.js and mdpTimePicker.js I'll merge it to master.

@laguiz
Copy link
Author

laguiz commented May 16, 2018

@dpoetzsch I'll try to create a PR. I Keep you informed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants