Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (stream): XRANGE incorrectly interprets the end parameter #4443

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix (stream): XRANGE incorrectly interprets the end parameter #4443

wants to merge 1 commit into from
+35 −6

Conversation

adiholden
Copy link
Collaborator

fix #4440

@adiholden adiholden requested a review from chakaz January 12, 2025 15:24
chakaz
chakaz reviewed Jan 12, 2025
View reviewed changes
src/server/stream_family.cc
@@ -257,15 +257,16 @@ bool ParseID(string_view strid, bool strict, uint64_t missing_seq, ParsedStreamI
return true;
}

bool ParseRangeId(string_view id, RangeId* dest) {
enum class RangeBoundary { kStart, kEnd };
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤓

src/server/stream_family_test.cc
Comment on lines +96 to +98
TEST_F(StreamFamilyTest, Xrange) {
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to add some tests here?

src/server/stream_family_test.cc
@@ -111,6 +114,29 @@ TEST_F(StreamFamilyTest, Range) {
sub1 = sub_arr[1].GetVec();
EXPECT_THAT(sub0, ElementsAre("1-1", ArrLen(2)));
EXPECT_THAT(sub1, ElementsAre("1-0", ArrLen(2)));

Run({"xadd", "mystream", "1609459200000-0", "0", "0"});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in a different TEST_F fixture?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chakaz chakaz chakaz left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XRANGE incorrectly interprets the end parameter when only the timestamp portion is provided
2 participants
@adiholden @chakaz