You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The XMICodec could be adapted to actually handle all cases where we use the default EMF serialization without problems (by using the emf model registry).
The main issue right now is, that the Codec interface does not accept a format parameter in encode and decode.
I thus suggest to change the Codec interface to include the format parameter, thus allowing us to have one XMICodec which can handle all EMF resources correctly. Furthermore many clients would not need to extend the MOdelServerClient anymore.
What do you think?
The text was updated successfully, but these errors were encountered:
So I stumbled over the point, that whenever we use the modelserver with a new emf model, we basically need to create an own ModelServerClient subclass as well as a XMICodec subclass see: https://github.com/eclipse-emfcloud/coffee-editor/blob/glsp-update/backend/plugins/org.eclipse.emfcloud.coffee.modelserver/src/org/eclipse/emfcloud/coffee/modelserver/CoffeeModelServerClient.java#L63 and https://github.com/eclipse-emfcloud/coffee-editor/blob/7f42783e0dcf290696db75ad8e94dbac965c5114/backend/plugins/org.eclipse.emfcloud.coffee.modelserver/src/org/eclipse/emfcloud/coffee/modelserver/CoffeeCodec.java#L23
The XMICodec could be adapted to actually handle all cases where we use the default EMF serialization without problems (by using the emf model registry).
The main issue right now is, that the Codec interface does not accept a format parameter in encode and decode.
I thus suggest to change the Codec interface to include the format parameter, thus allowing us to have one XMICodec which can handle all EMF resources correctly. Furthermore many clients would not need to extend the MOdelServerClient anymore.
What do you think?
The text was updated successfully, but these errors were encountered: