Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently use URI type internally #255

Closed
ndoschek opened this issue Oct 18, 2022 · 1 comment
Closed

Consistently use URI type internally #255

ndoschek opened this issue Oct 18, 2022 · 1 comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request modelserver EMF.cloud Model Server

Comments

@ndoschek
Copy link
Contributor

Consistently use URI type in internal and client API for modelUri handling.
Currently we use mostly the String type and convert it to an URI for checks. We should transform the received modeluri immediately to an URI type and continue using it throughout.
Also consider using the URI type in the client API.
@ndoschek ndoschek added enhancement New feature or request modelserver EMF.cloud Model Server labels Oct 18, 2022
@ndoschek ndoschek added the duplicate This issue or pull request already exists label Dec 1, 2022
@ndoschek
Copy link
Contributor Author

ndoschek commented Dec 1, 2022

Duplicate of #191

@ndoschek ndoschek marked this as a duplicate of #191 Dec 1, 2022
@ndoschek ndoschek closed this as completed Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists enhancement New feature or request modelserver EMF.cloud Model Server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ndoschek