Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve the overload in GitHubScanner methods fetch #1258

Open
sofiabobadilla opened this issue Sep 1, 2022 · 1 comment
Open

Resolve the overload in GitHubScanner methods fetch #1258

sofiabobadilla opened this issue Sep 1, 2022 · 1 comment

Comments

@sofiabobadilla
Copy link
Contributor

Link to the class GitHubScanner

methods fetch(long startTime, long endTime, FetchMode fetchMode, Set repos) and fetch(FetchMode fetchMode, Set repos) shouldn't share the name and should be documented.

Why overloading doesn't support the SOLID principle Open/Closed?
@sofiabobadilla
Copy link
Contributor Author

FYI I can't assigned myself, but I'm working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sofiabobadilla