Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render tooltips Theia theme aware #14075

Open
sgraband opened this issue Aug 27, 2024 · 1 comment
Open

Render tooltips Theia theme aware #14075

sgraband opened this issue Aug 27, 2024 · 1 comment

Comments

@sgraband
Copy link
Contributor

Feature Description:

Currently all of the tooltips in the standard views (e.g. explorer, problems, ...) are rendered using plain HTML. Therefore, the tooltips are styled according to the users global system theme and not the active Theia theme. This can lead to inconsistencies, which frankly do not look nice:
image_720

We should investigate, if there are any downsides to using the already exsting HoverService, which would style the tooltips better and would be consistent with the theme.
Another idea would be to investigate whether or not one could mock/fake the system theme so that the tooltips are at least rendered correctly in light/dark theme.
This could also be turned on/off via a setting similar to how it has been done with the tab-bar hover styling.

mvtec-richter added a commit to mvtecsoftware/theia that referenced this issue Feb 25, 2025
* Sync theia dark/light theme setting with electron nativeTheme setting
* This is to have native tooltips matching to the dark/light setting of the current theme

Fixes eclipse-theia#14075

Signed-off-by: Florian Richter <[email protected]>
@mvtec-richter
Copy link
Contributor

The PR #15037 only partially addresses this issue:
The tooltip now follow the dark/light setting of the Theia theme only on Windows and MacOS in the electron application. On Linux changing dark/light mode of an electron application is not implemented in electron. For browser applications, changing the native theme is not possible.

@sgraband sgraband reopened this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants