Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window.autoDetectColorScheme referenced in workbench.colorTheme setting does not exist #15098

Open
chroberino opened this issue Mar 3, 2025 · 3 comments
Labels
preferences issues related to preferences

Comments

@chroberino
Copy link

Bug Description:

The configuration settings for workbench.colorTheme in Theia contain a reference to window.autoDetectColorScheme, which does not appear to exist in Theia:

'workbench.colorTheme': {
    type: 'string',
    enum: ['dark', 'light', 'hc-theia'],
    enumItemLabels: ['Dark (Theia)', 'Light (Theia)', 'High Contrast (Theia)'],
    default: DefaultTheme.defaultForOSTheme(FrontendApplicationConfigProvider.get().defaultTheme),
    description: nls.localizeByDefault('Specifies the color theme used in the workbench when {0} is not enabled.', '`#window.autoDetectColorScheme#`')
}

Image

In VS Code, window.autoDetectColorScheme is used to automatically switch between light and dark themes based on the OS setting. However, Theia does not currently expose this property.

  • Is there a plan to implement window.autoDetectColorScheme in Theia?
  • If not, should the description of workbench.colorTheme be updated to remove this reference?

Steps to Reproduce:

  1. Open Theia's settings.
  2. Locate the workbench.colorTheme setting.
  3. Notice that the description references window.autoDetectColorScheme, which does not exist.

Additional Information

  • Operating System: Windows 10
  • Theia Version: 1.58.3
@msujew
Copy link
Member

msujew commented Mar 3, 2025

It probably makes sense to have this as a follow up of #15037.

@msujew msujew added the preferences issues related to preferences label Mar 3, 2025
@JonasHelming
Copy link
Contributor

@mvtec-richter

@mvtec-richter
Copy link
Contributor

I don't see much value in the window.autoDetectColorScheme option, especially because it's disabled by default.
I would suggest to change the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preferences issues related to preferences
Projects
None yet
Development

No branches or pull requests

4 participants