Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ai-chat): add space after all autocompletions in AI chat #15052

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

eneufeld
Copy link
Contributor

What it does

This change ensures proper spacing after autocompleted items by:

  • Removing unnecessary space when triggering the @ menu
  • Adding a space after each autocompleted item

fixed #15051

How to test

In the ai chat, trigger the autocompletion using #, @ or ~, then select an item and see that you can continue typing after selecting the entry

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

This change ensures proper spacing after autocompleted items by:
- Removing unnecessary space when triggering the @ menu
- Adding a space after each autocompleted item

fixed eclipse-theia#15051
@JonasHelming JonasHelming requested a review from planger February 27, 2025 07:50
Copy link
Contributor

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 👍

@eneufeld eneufeld merged commit eaacdbf into eclipse-theia:master Mar 1, 2025
10 of 11 checks passed
@eneufeld eneufeld deleted the GH-15051 branch March 1, 2025 08:49
@github-actions github-actions bot added this to the 1.60.0 milestone Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Theia AI] Pin Agent - minor issue: need to add space after this operation
2 participants