Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

Fetch CloudState protocol files from Eigr Functions #14

Open
sleipnir opened this issue Feb 24, 2021 · 9 comments
Open

Fetch CloudState protocol files from Eigr Functions #14

sleipnir opened this issue Feb 24, 2021 · 9 comments
Labels

Comments

@sleipnir
Copy link
Member

sleipnir commented Feb 24, 2021

We need to change fetch-cloudstate-pb.sh to pull files from Permastate instead of CloudState repository

@sleipnir sleipnir added good first issue Good for newcomers platform labels Feb 24, 2021
@marcellanz
Copy link
Member

Agree.
One tought i had was, would we version the protocol? or is that too early to think like that.

@sleipnir
Copy link
Member Author

I think this is the time to think about it

@marcellanz
Copy link
Member

Nice. I take dapr as an example how we could do it:
https://github.com/dapr/dapr/tree/master/dapr/proto/common/v1

Also, I found the organization, especially with tools, a bit strange how CS did it.

@sleipnir
Copy link
Member Author

Okay. Let's do better

@sleipnir
Copy link
Member Author

Nice. I take dapr as an example how we could do it:
https://github.com/dapr/dapr/tree/master/dapr/proto/common/v1

Also, I found the organization, especially with tools, a bit strange how CS did it.

For me is fine to use this Dapr format

@sleipnir
Copy link
Member Author

This item is extremely relevant too. If anyone wants to attack he would be nice. I believe that the current protobufs are out of date.

@marcellanz
Copy link
Member

I'd be happy to, I can give some input from the Go perspective as I had to strech a bit the go package structure for the existing proto files.

@sleipnir
Copy link
Member Author

Ok. Very cool!
I think some work I also had to do to make it work with Elixir, but I don't remember for sure

@sleipnir
Copy link
Member Author

I think we can migrate to https://buf.build/

@sleipnir sleipnir changed the title Fetch CloudState protocol files from Permastate Fetch CloudState protocol files from Eigr Functions Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants