Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split header #2509

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Split header #2509

wants to merge 2 commits into from

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Oct 18, 2024

Fixes #2456

Splits header with sidebar header just containing the close button
Moving or adding other tools to the sidebar header is left for further PRs as required.

@jeremypw jeremypw marked this pull request as ready for review October 18, 2024 15:18
@alainm23
Copy link

alainm23 commented Oct 18, 2024

The design change feels much better, just one question. There is a reason why the navigation buttons (back and forward) are aligned to the center and not to the right?

@danirabbit
Copy link
Member

I think the navigation buttons should stay in the right side pane with the view since that's the thing that they take action on. All of our prior art has these buttons in the right side pane as well.

The reason the back button is in the sidebar in System Settings is because it does take action on the entire view including the sidebar there. But here, going back or forward doesn't change the sidebar it just changes the view

@jeremypw
Copy link
Collaborator Author

@danirabbit OK. Is there any other widget that can be moved into the sidebar header to save space on the rh pane? For comparison, Gnome Files has the AppMenu there.

@danirabbit
Copy link
Member

GNOME Files has 3 menus, 2 of which are in the right side pane

A menu in the sidebar for some app-wide functions
Screenshot from 2024-10-18 13 59 29

A menu on the pathbar for actions specific to that folder/path:
Screenshot from 2024-10-18 14 00 07

A menu for view options
Screenshot from 2024-10-18 13 59 46

So we already have 2 fewer menus than GNOME Files and 1 fewer menus in the right side pane 😅

@jeremypw
Copy link
Collaborator Author

@danirabbit So nothing in the sidebar header except the close button? If that is the case I am inclined to withdraw this PR as it achieves little and squashes up the widgets in the rh toolbar.

@jeremypw
Copy link
Collaborator Author

Appearance after reversion:
Screenshot from 2024-10-19 16 21 29

@jeremypw
Copy link
Collaborator Author

@teamcons If we are going to enforce the mantra that the sidebar header can only contain things that act on the sidebar then a search button there would be expected to search amongst the bookmarks, not the view. A search button that acts on the view should be in the view header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split header bar in a similar way to several other elementaryos apps
3 participants