Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: status.img_alt.read cannot be properly translated #3006

Open
palant opened this issue Oct 19, 2024 · 1 comment
Open

i18n: status.img_alt.read cannot be properly translated #3006

palant opened this issue Oct 19, 2024 · 1 comment
Labels
c: bug Something isn't working c: i18n Enhance i18n

Comments

@palant
Copy link
Contributor

palant commented Oct 19, 2024

The localization string status.img_alt.read has a placeholder which is replaced by either image or video. As the inserted string isn’t localized, this only works correctly in English. Any translations are bound to be awkward or plain wrong.

Note that even with translated attachment types composing sentences like this is quite problematic. E.g. in German “image description” translates as a composite word: “Bildbeschreibung”.

Maybe it’s better to have separate strings for each individual attachment type?

@palant palant added c: bug Something isn't working s: pending triage Pending Triage labels Oct 19, 2024
@shuuji3
Copy link
Member

shuuji3 commented Oct 20, 2024

I see. I agree we need to adjust this string to avoid incorrect translations.

The media type could be one of 5 values listed here: https://github.com/neet/masto.js/blob/main/src/mastodon/entities/v1/media-attachment.ts#L1-L6 So, if we add separate strings, we will need to prepare five different translations for every language. Alternatively, we could simplify it as "Read description". I wonder which one would be better in this case.

@shuuji3 shuuji3 added c: i18n Enhance i18n and removed s: pending triage Pending Triage labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working c: i18n Enhance i18n
Projects
None yet
Development

No branches or pull requests

2 participants