Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align examples port: 10090 with what is default in gui and readme.md #35

Open
andy778 opened this issue Jul 27, 2023 · 0 comments
Open

Comments

@andy778
Copy link

andy778 commented Jul 27, 2023

Would be convenient for first time users if this default is right as found from https://github.com/home-assistant/core/blob/dev/homeassistant/components/nibe_heatpump/config_flow.py

target:
- ip: 192.168.16.130
port: 10090 -> 9999

Exist in both lilygo-t-can485.yaml and esp32_max485.yaml

elupus pushed a commit that referenced this issue Oct 7, 2023
While I'm a developer it still took me a bit of time to get going with
the LilyGo T-CAN485. Hope it will takes less time of others with these
hints.

So making the LilyGo T-CAN485 sample easier for first timers:

- The reamde.md recommends to disable WiFi powersave, also added that in
the sample.
- The readme doesn't talk about a static IP, while it's quite practical
to have that.
- I was a bit in the unclear that target address needs to go to home
assistant. Didn't expect the UDP listener in HA. Hinted now that the
target IP goes to HA when HA is used.
- Quite some people will use this with Home Assistant where the default
UDP port is 9999. Also changed to that port in the sample. Also see
issue #35.
- Added some comments around the read and write ports and their
defaults. Makes it a bit easier to do the Home Assistant Nibe setup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant