Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we get rid of serde(bound) annotations? #10

Open
fjarri opened this issue Apr 12, 2023 · 3 comments
Open

Can we get rid of serde(bound) annotations? #10

fjarri opened this issue Apr 12, 2023 · 3 comments
Labels
code quality Making things simpler
Milestone
v1.0.0

Comments

@fjarri
Copy link
Member

fjarri commented Apr 12, 2023

Because of some dark magic in serde-derive, we often need to specify explicit bounds when deriving Serialize/Deserialize. See https://serde.rs/attr-bound.html for the explanation of the problem. Is it possible to get rid of them somehow?
@fjarri fjarri added the code quality Making things simpler label Apr 12, 2023
@fjarri
Copy link
Member Author

fjarri commented Jun 7, 2023

The issue is caused by serde's bad bound heuristic for generic types. See serde-rs/serde#2463

@fjarri fjarri added this to the v1.0.0 milestone Nov 26, 2023
@fjarri fjarri mentioned this issue Jun 3, 2024
Merged
@fjarri
Copy link
Member Author

fjarri commented Oct 12, 2024

Note: may be possible if ModProg/derive-where#100 is fixed.

@fjarri fjarri mentioned this issue Feb 5, 2025
Merged
@fjarri
Copy link
Member Author

fjarri commented Feb 6, 2025

Also maybe we can just derive Serialize for our empty types and it'll satisfy the bounds?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Making things simpler
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@fjarri