Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for including metadata in requests tapped by tap filter #38449

Open
onemanbucket opened this issue Feb 13, 2025 · 0 comments
Open
Labels

Comments

@onemanbucket
Copy link
Contributor

Title: Add support for including metadata in requests tapped by tap filter

Description:
We use the tap filter to sample perimeter traffic for building a traffic insights dataset. We want to attach some information to the sampled requests, so we set some route metadata which is then added as a request header. This lets us attach metadata to the request sampled by the tap filter, but it has the downside that the metadata headers are sent to our upstreams which leaks internal information and is something we would avoid.

I'm not sure what the best approach here would be, but the naive approach could be to extend the tap filter with a list of "tap-only headers" which will be dropped from the request. This seems straightforward, although it means that the filter would mutate the headers which I don't think it does today.

@onemanbucket onemanbucket added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Feb 13, 2025
@mattklein123 mattklein123 added area/tap and removed enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants